Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get_slicec instead of get_slice for single character splitters #99321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use get_slicec instead of get_slice for single character splitters #99321

wants to merge 1 commit into from

Conversation

AThousandShips
Copy link
Member

This method exists for this dedicated purpose and is faster for these kinds of input

@AThousandShips AThousandShips added this to the 4.4 milestone Nov 16, 2024
@AThousandShips AThousandShips requested review from a team as code owners November 16, 2024 16:27
Calinou
Calinou approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement performance
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @Calinou