Add clarification on WorkerThreadPool threadcount
#99317
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/godotengine/godot/blob/master/core/os/os.h https://github.com/godotengine/godot/blob/master/platform/web/os_web.h Sources here https://github.com/godotengine/godot/blob/master/core/os/os.h#L91 https://github.com/godotengine/godot/blob/master/platform/web/os_web.h#319 https://github.com/godotengine/godot/blob/master/core/object/worker_thread_pool.cpp#L752 Note that although web returns 1, the max threads is the returned processors - 1 so no multithreading on web
AThousandShips
changed the title
WorkerThreadPool threadcount
|
@Mickeon @AThousandShips Sorry for accidentally closing the last pull request, I was having trouble with github since I made another pull request but ran into some issues with syncing and etc (since I forgot to sync) so I deleted the last branch! I was working on some stuff for threadpools and etc on the code side which wouldn't have been in the same pull request and got super jumbled up haha ^^; This is the same request although please do check over it again if you'd like 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/godotengine/godot/blob/master/core/os/os.h https://github.com/godotengine/godot/blob/master/platform/web/os_web.h
Sources here
https://github.com/godotengine/godot/blob/master/core/os/os.h#L91 https://github.com/godotengine/godot/blob/master/platform/web/os_web.h#319 https://github.com/godotengine/godot/blob/master/core/object/worker_thread_pool.cpp#L752
Note that although web returns 1, the max threads is the returned processors - 1 so no multithreading on web