Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RID Max Allocation Project Setting #99307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justofisker
Copy link
Contributor

@justofisker justofisker commented Nov 16, 2024

Fixes #99162

Not fully confident about the name of this setting. Also basically my first PR so would love feedback of any kind.

Add a project setting for the maximum allocations per RID_Alloc.

When p_maximum_number_of_elements is 0 the project setting will be used. The default value is now 0.

@justofisker justofisker requested review from a team as code owners November 16, 2024 04:14
@RedMser
Copy link
Contributor

RedMser commented Nov 16, 2024

You have to squash your commits into one, see the docs for this here: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase

@justofisker justofisker force-pushed the max-rid-allocation-project-setting branch from 9dd7c8b to 5aae9de Compare November 16, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.4 dev 4] RenderingServer.InstanceCreate() with large instance count triggers seg fault
3 participants