Remove warning when project setting requests a larger global shader uniform buffer than the hardware supports #93645
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 27, 2024
akien-mga
approved these changes
Jun 27, 2024
akien-mga
force-pushed
the
shader_global_warning
branch
from
bae42e0
to
f34fc67
Compare
…niform buffer than the hardware supports. Instead provide a better error message when the limit is exceeded and avoid crash with a small limit.
akien-mga
force-pushed
the
shader_global_warning
branch
from
f34fc67
to
27b040d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead provide a better error message when the limit is exceeded and avoid crash with a small limit.
Fixes: #85374
Tagging for 4.3 since the warning is now shown on every project now that we properly calculate the maximum buffer size.
In the future we may want to explore a way to provide more global uniforms (i.e. provide multiple UBOs or store data in a texture). But we should only do that if there is significant demand. This should be fine for now.