Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate animation for SpriteFrames #93624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EAinsley
Copy link
Contributor

@EAinsley EAinsley commented Jun 26, 2024

This is a continue work of #80380.
Close godotengine/godot-proposals#3942.

anim.tscn.-.Testing.-.Godot.Engine.2024-06-26.17-31-34.mp4

@AThousandShips
Copy link
Member

You've made them the author and made yourself the co author, it should be the other way around

@EAinsley
Copy link
Contributor Author

You've made them the author and made yourself the co author, it should be the other way around

It was intentional. I thought he did most of the work. Anyway, updated.

scene/resources/sprite_frames.cpp Outdated Show resolved Hide resolved
doc/classes/SpriteFrames.xml Outdated Show resolved Hide resolved
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but it works correctly.

@EAinsley
Copy link
Contributor Author

Left some comments, but it works correctly.

Thank you! They are really helpful.

Co-authored-by: Nonunknown <[email protected]>
@EAinsley
Copy link
Contributor Author

Would this be merged?

@akien-mga
Copy link
Member

We're in feature freeze for Godot 4.3, so this kind of change would be merged after the 4.3 release is done, for 4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Duplicate button and context menu to the SpriteFrames editor
5 participants