Repository navigation
Conversation
Contributor
Author
|
Also for the check below, is there any reason that it is after the code for removal or can it be pushed fowards so that crashes of this kind don't happen? ERR_FAIL_COND_MSG(
changing_type_index == EditorPropertyArrayObject::NOT_CHANGING_TYPE,
"Tried to change type of an array item, but no item was selected."); |
AegisTTN
changed the title
EditorPropertyArray type changing and removal on remote treeEditorPropertyArray type changing and removal on Remote Inspector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Additional information
Implement the same fix as #116843 but for Array.
Fixes the reported crash and also the ability to edit the type as before it would give an error ("Tried to change type of an array item, but no item was selected.")