Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95308
Before Fix: Audible clicks and pops when toggling effects' enable or buses' bypass. The original code directly skips effect processing when an effect is disabled or a bus is bypassed, which changes the wet (processed) signal to the dry (unprocessed) signal, creating abrupt changes in the waveform.
After Fix: A linear
5 mscrossfade is applied to every effect on toggling enable/bypass. It crossfades dry and wet signals to smooth out the change. In the tested cases, no audible clicks were generated.The implementation has every
Effectstruct keep its ownwet_mixstate. The state is initialized when adding new effects to a bus, and it checks if both the effect is enabled and the bus is not bypassed. All channels use the same mix value to keep the processing synchronized. The state is updated per buffer block after all channels finish processing.The code skips effect processing only after the targeted effect is
disabledor the bus isbypassedand the mix has reached 100% dry.Notice that the current implementation individually crossfades each effect when choosing to bypass the bus.
Tested on Windows with version
4.8.betabased on commitc8256a8. Tested cases:Clicks and pops do not occur in the above situations.
Recording Waveform at effect enable point:
Before Fix

After Fix

AI Usage
Discussed test cases and identified possible causes. Reviewed code style and comments.