Convert the bottom VCS dock to a EditorDock and tie it with the Commit dock
#115482
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
reviewed
Jan 28, 2026
| } | ||
|
|
||
| if (!p_dock->is_open) { | ||
| p_dock->emit_signal("opened"); |
Contributor
There was a problem hiding this comment.
This should be in EditorDockManager::open_dock(), especially because EditorDock::open and EditorDock::make_visible do not call this function
Member
Author
There was a problem hiding this comment.
Just like the closed signal only fires in the specific case of clicking the "Close" button in the editor. I chose consistency is this case, and I think it works for most needs.
YeldhamDev
force-pushed
the
vsc_dock_stuff
branch
from
ed3abbe to
4a5eb23
Compare
Member
My PR also fixed this. It's a bug in EditorDock. |
Member
Author
|
@KoBeWi Oh, I missed that! I will incorporate the right fix on this one (with co-authoring). |
…mit dock Co-authored-by: Tomasz Chabora <[email protected]>
YeldhamDev
force-pushed
the
vsc_dock_stuff
branch
from
4a5eb23 to
d2b8e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the same objective as #113454 but from another approach: it makes so that the bottom dock follows the Commit dock's state instead of being its own thing. That means that it can't be closed directly, but closes if the Commit dock is closed.
Some other changes were necessary:
is_floating()method, that simply returns if the dock is in a separate window.openedsignal, which is fired when the dock is enabled via the "Editor > Editor Docks" menu.This PR also fixes a bug: when the connection to the VCS is disabled and then re-enabled, only the bottom dock would re-appear.
The only thing missing from this compared to #113454 is the new icon, which can be added later on included in this PR, whatever is preferable.