Skip to content

Conversation

@realbucketofchicken
Copy link

This PR implements a queue_update() function to update a reflection probe without having to change its position.

closes godotengine/godot-proposals#13466

This is the first time ive worked with godots source code so please excuse me if i forgot something.

@realbucketofchicken realbucketofchicken requested review from a team as code owners October 27, 2025 20:40
@realbucketofchicken realbucketofchicken force-pushed the reflection-probe-queue-update-function branch 2 times, most recently from b557342 to 6e598de Compare October 27, 2025 21:38
@AThousandShips AThousandShips added this to the 4.x milestone Oct 27, 2025
@realbucketofchicken realbucketofchicken force-pushed the reflection-probe-queue-update-function branch 4 times, most recently from ee9f236 to eb076e7 Compare October 27, 2025 22:49
@aaronfranke
Copy link
Member

@realbucketofchicken Please do your testing offline or on a branch that isn't submitted as a pull request, and push less frequently. Pushing so many times in a row creates lots pending of CI jobs.

@realbucketofchicken
Copy link
Author

Ah i didnt know that, I will do my testing on a separate branch from now on. Thanks for telling me

@realbucketofchicken realbucketofchicken force-pushed the reflection-probe-queue-update-function branch from eb076e7 to 59fd81c Compare October 28, 2025 05:54
@AThousandShips AThousandShips changed the title add queue_update() to reflection probes Add queue_update() to reflection probes Oct 28, 2025
@realbucketofchicken realbucketofchicken force-pushed the reflection-probe-queue-update-function branch from 59fd81c to ef08e4d Compare October 28, 2025 12:44
@realbucketofchicken realbucketofchicken force-pushed the reflection-probe-queue-update-function branch from ef08e4d to 7591552 Compare October 28, 2025 13:18
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in all renderers, it works as expected. Code looks good to me.

Note that if you call queue_update() every frame, it will stop working after the reflection probe updates twice. However, this also occurs if you change the probe's rotation continuously (the previous workaround). This is also an issue on master, so this may have regressed recently (as I recall it working correctly before, i.e. the probe appears to update every ~12 rendered frames).

Testing project: test_pr_112101.zip
The project is capped at 60 FPS by default to ensure consistent update speeds across devices. Change this in the Project Settings if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a method to force a ReflectionProbe to update

5 participants