Add extra cull margin to Light3D #112098
Open
Add extra cull margin to Light3D #112098
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes parameters similar to GeometryInstance3D to allow modifying the cull margin.
|
I have no clue why this is somehow failing the doc check on Linux / Editor w / Mono. Do the members have to be in alphabetical order perhaps? |
The CI failure is due to incorrect indentation (use 2 tab characters instead of 8 spaces). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes extra cull margin parameters similar to GeometryInstance3D to allow modifying the cull margin. This fixes #105063 in the Compatibility and Mobile renderers by letting the user account for the effect of vertices being lit outside of the light's radius (due to vertex interpolation).
This functionality is already in the base VisualInstance3D class and only needs to be exposed to be of use.