-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Fix PopupMenu losing item highlight when hovering submenus
#112095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee89b71 to
89939e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Linux (X11) with single-window mode disabled, it doesn't work on my end. The highlight is still gone when using mouse navigation (with or without clicking to make the submenu appear earlier), although it works with keyboard navigation like it did before.
popupmenu_highlight_editor.mp4
|
Well, the problem is that I'm on Fedora Kinoite, which makes it a little convoluted for me to install X11 in order to test this. 😖 |
89939e0 to
c220a71
Compare
|
@Calinou Try again, should be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now 🙂
Code looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working on macOS and Windows.
Sometimes it's blinking when mouse is moving to submenu, but it's hard to reproduce:
Untitled.mov
c220a71 to
c5fe5d4
Compare
|
Thanks! |
Used to work before, but broke somewhere down the road.