Skip to content

Conversation

@YeldhamDev
Copy link
Member

Used to work before, but broke somewhere down the road.

Before After
Screenshot_20251027_120040 Screenshot_20251027_115726

@YeldhamDev YeldhamDev added this to the 4.6 milestone Oct 27, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner October 27, 2025 15:30
@YeldhamDev YeldhamDev added bug topic:gui cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 27, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Linux (X11) with single-window mode disabled, it doesn't work on my end. The highlight is still gone when using mouse navigation (with or without clicking to make the submenu appear earlier), although it works with keyboard navigation like it did before.

popupmenu_highlight_editor.mp4

@YeldhamDev
Copy link
Member Author

YeldhamDev commented Oct 28, 2025

Well, the problem is that I'm on Fedora Kinoite, which makes it a little convoluted for me to install X11 in order to test this. 😖

@YeldhamDev
Copy link
Member Author

@Calinou Try again, should be fixed.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now 🙂

Code looks good to me.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working on macOS and Windows.

Sometimes it's blinking when mouse is moving to submenu, but it's hard to reproduce:

Untitled.mov

@Repiteo Repiteo merged commit 250ef8d into godotengine:master Oct 30, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the subpop_hl_fix branch October 30, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release topic:gui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants