-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Move localized number formatting methods to TranslationServer
#112092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing text server specific to these methods, and TextServerAdvance implementation is not using ICU (since we are not compiling localization part of it, which is handling similar stuff), so TranslationServer is indeed a better place for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is going to be mildly annoying for localization, ironically. The descriptions between the old and new methods are so similar, if it weren't for the language-to-locale change, so this will inevitably create more translation strings.
Consider duplicating the description to the deprecated methods to ease the burden at least.
Co-Authored-By: Pāvels Nadtočajevs <[email protected]>
|
I added a description of the behavior when |
Closes #96105. The idea is salvaged from it.
This PR transfers
format_number(),parse_number(), andprecent_sign()fromTextServertoTranslationServer.TextServerandTextServerExtensionare deprecated, but still kept for compatibility.Godot should look exactly the same after this change. Most work to explicitly specify the language has been done in #110378.