Add an easy way to reload editor addons

[DexterFstone]

closes godotengine/godot-proposals#13308

Adds a new menu to Editor, allowing you to select a plugin and reload it whenever you want

Add 3 new menu items to ScriptEditor, allowing to Enable Plugin, Disable Plugin, and Reload Plugin

Edit:
Adds a new submenu to the FileSystem context menu called Plugins... that shows all selected plugins, and their state as a checkbox. If the addons folder is selected, it shows all plugins instead

Also, work with the internal addon files and folders

~

[kitbdev]

• The linked proposal doesn't mention adding this to the ScriptEditor. There are related proposals that also don't mention it either: Add plugin hot-reload and reload shortcut support godot-proposals#11612 and Reload plugin with RMB on plugin.cfg or the plugin folder godot-proposals#13503 (comment)

Needing the plugin to be open in the internal ScriptEditor loses some of the utility wanted in the proposals. I think this would be better in the FileSystem dock.

Also the options should only be available for plugins and they should depend on the state of the plugin. Eg. there shouldn't be an option to disable an already disabled plugin.

[DexterFstone]

Makes sense, my idea was for the plugin developer and not the user

[KoBeWi]

It's missing a shortcut to toggle an addon. The menu is an improvement over the current workflow, but it's still not ideal.

Also not sure if having to right-click a specific folder is discoverable.

[DexterFstone]

It's missing a shortcut to toggle an addon.

How to handle shortcuts for dynamic menu items? Adding the ability to favorite 5 different add-ons and register 5 different shortcuts? "filesystem_dock/toggle_plugin_*"

[DexterFstone]

Or a new shortcut field in the Plugins tab in Project settings?

[DexterFstone]

Also, not sure if having to right-click a specific folder is discoverable.

I could make it global, so as long as you right-click in the file system, the plugins can be toggled

[KoBeWi]

Well, the proposal already comes with a solution for shortcuts.

Adding the ability to favorite 5 different add-ons and register 5 different shortcuts?

This is only needed for editor, having that many extra settings is too much I think.
And having one favorite addon means you have to go to project settings and change it when you want to toggle different addon.

Or a new shortcut field in the Plugins tab in Project settings?

That's overkill, not every plugin needs it, and it isn't useful for regular usage.

I could make it global, so as long as you right-click in the file system, the plugins can be toggled

So like, adding yet another way to toggle addons?

[DexterFstone]

Well, the proposal already comes with a solution for shortcuts.

Ok then, I will try the menu under Editor

[AdriaandeJongh]

Hey! Thanks for working on this @DexterFstone!

I think the UX of this can be greatly simplified by avoiding to spawn a submenu, and by simplifying the logic. The most common use case for this toggle will be to enable / disable a single and specific plugin, and I want to make the case that this action alone covers 90% of the proposed feature improvement. Other user actions, such as enabling and disabling multiple plugins at once, are already best done in the player settings plugins window.

So while showing the submenu when you RMB on the addons folder or RMB when you have multiple selected, the added submenu step is IMO unnecessary added complexity.

I propose the following:

• no 'plugins > plugin_name' sub menu.
• when RMB on a folder containing a plugin.cfg or on the plugin.cfg itself, show an item in the context menu under the folder color item that has a toggle telling it's current active state and with the text 'Enable plugin' (regardless of the state).
• when multiple folders / plugin.cfg files are selected, take the enabled state of the plugin you end up RMB on and apply any changes to that state to all other selected plugins, eg: when I select plugin A (disabled) and plugin B (enabled) and plugin C (disabled) and I RMB on plugin A, the toggle will show as off, and clicking Enable plugin will enable all plugins.
• I would suggest not adding any plugin toggle actions to the context menu of the addons folder.

I don't know if Godot even has a third toggle state for checkboxes, but many programs do: where, if you multi-select, instead of showing an empty or checked checkbox, it shows a minus in the checkbox indicating the state is mixed. That would have been ideal for the multi select issue, but if Godot doesn't support that, then we shouldn't bother.

[DexterFstone]

@AdriaandeJongh, tnx for your feedback, I've already removed the File System context menu, I'm currently adding a menu to Editor similar to the proposal

I don't know if Godot even has a third toggle state for checkboxes, but many programs do: where, if you multi-select, instead of showing an empty or checked checkbox, it shows a minus in the checkbox indicating the state is mixed. That would have been ideal for the multi select issue, but if Godot doesn't support that, then we shouldn't bother.

Icon already exists (GuiIndeterminate.svg), and is used for Tree, maybe someone can implement it later

[AdriaandeJongh]

similar to the proposal

Ah, dang, we are mixing up two different proposals here. I was coming from godotengine/godot-proposals#13503 (comment) which does involve the FileSystem, but if you've moved away from that, this PR won't address that proposal.