Skip to content

Conversation

@lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Oct 22, 2025

Backport of #111771

Notes

  • We don't have clipper2 in 3.x, so only require this part.
  • This doesn't fail CI in 3.x, but might be useful for newer versions of GCC.
  • I'm not completely convinced this is worth changing, but included as an option.

@lawnjelly lawnjelly added this to the 3.x milestone Oct 22, 2025
@akien-mga akien-mga modified the milestones: 3.x, 3.7 Oct 22, 2025
@akien-mga akien-mga added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Oct 22, 2025
@akien-mga
Copy link
Member

akien-mga commented Oct 22, 2025

So it seems it's not failing on CI currently because we don't build with mingw-gcc 15 on Windows, unlike on master.

I did a quick test with mingw-gcc 15 in a Fedora 43 container and found a number of other warnings (but not this one, might depend on optimization level), so they should probably be tackled in a dedicated PR and not just cherry-picking this single change. It's not a blocker for 3.6.2 anyway since it's not breaking our current CI, so I think we can skip this one.

Build log from scons p=windows warnings=extra on Fedora 43 with mingw-gcc 15.2.1:

godot-3.x-f43-mingw-gcc-15.2.1.log

@akien-mga akien-mga closed this Oct 22, 2025
@akien-mga akien-mga added archived and removed cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Oct 22, 2025
@akien-mga akien-mga removed this from the 3.7 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants