Skip to content

Conversation

Ivorforce
Copy link
Member

@Ivorforce Ivorforce commented Oct 6, 2025

In our main setup, types are being registered out of order. This denies us from making confident caches, because the parent may not be fully registered by the time the child is registered.

This PR is a first, small step towards making them ordered. This prepares for the eventual merge of #106873, by reducing the number of warnings it would raise.

Since there will be a handful of PRs like this, I'll try to keep them thematically consistent, to make review easier.

@Ivorforce Ivorforce added this to the 4.6 milestone Oct 6, 2025
@Ivorforce Ivorforce requested a review from a team as a code owner October 6, 2025 08:56
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These changes look good to me. I'm actually surprised at how minimal the changes are for the core types - I had thought the situation was much worse :-)

@Ivorforce
Copy link
Member Author

I had thought the situation was much worse :-)

There are a bunch more, but most of the rest isn't as straight forward. I'm just taking it slow 😅

@Repiteo Repiteo changed the title Improve type registration order in register_core_types.cpp. Improve type registration order in register_core_types.cpp. Oct 7, 2025
@Repiteo Repiteo merged commit 9c63619 into godotengine:master Oct 7, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 7, 2025

Thanks!

@Ivorforce Ivorforce deleted the registration-order-1 branch October 7, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants