[JoltPhysics] Fix Generic6DOFJoint3D not respecting angular limits #111087
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 6DOF constraint that constrains all rotation axis in combination with a body that has some of its rotation axis locked would not constrain the rotation in the unlocked axis. Fixes godotengine#109018
|
Note that merging this PR may not actually cause the affected cpp files to be recompiled due to a scons caching issue we found. You may need to force recompile. |
jrouwe
changed the title
AThousandShips
added
bug
topic:thirdparty
topic:physics
topic:3d
cherrypick:4.4
mihe
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
It does indeed seem to fix #109018, thanks!
@jrouwe would you say this is safe to cherrypick all the way back to Godot 4.4, i.e. jrouwe/JoltPhysics@f094082 (-ish), or does this fix depend on anything newer than that?
|
I think it should be safe yes. |
|
Thanks! |
|
Cherry-picked for 4.5.1. |
akien-mga
removed
the
cherrypick:4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 6DOF constraint that constrains all rotation axis in combination with a body that has some of its rotation axis locked would not constrain the rotation in the unlocked axis.
Fixes #109018