Fix drag and drop regression on touchscreens in Tree
#104657
Draft
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex2782
force-pushed
the
fix_tree_drag_and_drop
branch
from
0489abe to
f64d85d
Compare
Alex2782
force-pushed
the
fix_tree_drag_and_drop
branch
from
f64d85d to
f7f3e08
Compare
|
I don't think the code style sweep should be done as part of this, it pollutes the history |
Alex2782
force-pushed
the
fix_tree_drag_and_drop
branch
from
f7f3e08 to
17fedac
Compare
New PR for cleanup part #104708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102256
Fixes #100393
This concerns the user actions
drag scrollinganddrag & drop.There were conflicts, and drag & drop was disabled 8 months ago. There are several options for scrolling but none for drag and drop on touchscreens.More details: #94422 (comment)
This PR includes:
drag_scrolling_enabled(default = false)InputEventPanGestureadaptation for Android touchscreens (TODO)Test project: bug_102256_treedragtest.zip
14s video, Test on MacOS
with
Emulate Touch From MouseScreen-2025-03-26-173540.mp4
TODOs:
scroll_scale= 32 forInputEventPanGestureok withApple Magic Trackpad / Mouse / Android Touchscreens?drag_scrolling_enabled = true, where drag and drop is not possible ?