Add specific error for use of Godot 3 export syntax
#104636
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's worth adding a test to |
dalexeev
reviewed
Mar 26, 2025
Meorge
force-pushed
the
feat/export-syntax-error
branch
from
5838bc2 to
0e5da00
Compare
Meorge
force-pushed
the
feat/export-syntax-error
branch
from
0e5da00 to
031bfa6
Compare
Update modules/gdscript/gdscript_parser.cpp Co-authored-by: Danil Alexeev <[email protected]> Improve error message Add tests
Meorge
force-pushed
the
feat/export-syntax-error
branch
from
031bfa6 to
78b6cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#11542.
This PR adds a special error message for when the Godot 3
exportsyntax is used in a GDScript file:Note
As can be seen in the commit, the
(...)in the message is always included, even if the user types something likewith no arguments to
export.If necessary, I could try to get this to detect the presence of arguments and change the error message accordingly, but I suspect that may end up complicating the code for it a lot.