Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of size_2d_override to Vector2 #104602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timoschwarzer
Copy link
Contributor

Fixes #104601

Added compatibility methods that mimic the previous behavior.

@AThousandShips
Copy link
Member

AThousandShips commented Mar 25, 2025

This was already rejected in:

Where a different solution was decided on, so this isn't likely to be accepted

Adding compatibility binds for the setter/getter doesn't solve compatibility completely here, for example with C# which doesn't use them

@timoschwarzer timoschwarzer force-pushed the fix/subviewport-size-2d-override-float branch from c79b47f to 6108920 Compare March 25, 2025 13:30
@timoschwarzer timoschwarzer force-pushed the fix/subviewport-size-2d-override-float branch from 6108920 to 8c3a5b1 Compare March 25, 2025 14:53
@timoschwarzer timoschwarzer marked this pull request as ready for review March 25, 2025 15:11
@timoschwarzer timoschwarzer requested review from a team as code owners March 25, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubViewport size_2d_override is limited by being of type Vector2i
2 participants