Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shape always being zero with get_rest_info when using Jolt Physics #104599

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Mar 25, 2025

Fixes #104563.

Somehow I managed to copy this line (to ~15 lines above this one) instead of cutting it when doing some refactoring while porting the Jolt module, resulting in the shape index in the get_rest_info results always being zero.

@mihe mihe added bug topic:physics topic:3d cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Mar 25, 2025
@mihe mihe added this to the 4.5 milestone Mar 25, 2025
@mihe mihe requested a review from a team as a code owner March 25, 2025 11:38
@akien-mga akien-mga merged commit b699508 into godotengine:master Mar 25, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.4.1.

@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 25, 2025
@mihe mihe deleted the jolt/rest-info-shape-index branch March 26, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in Jolt Physics colliding shape index is always 0
2 participants