Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force multiple of 4 sizes for CVTT compressor. #104575

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 24, 2025

Same as #104275 but for High Quality VRAM Compression

Partially fixes - #102533 (other part is fixed by #104590)

@bruvzg
Copy link
Member Author

bruvzg commented Mar 24, 2025

In this case, adding padding changes behavior, so I'm not sure if this should be used as is.

@fire
Copy link
Member

fire commented Mar 24, 2025

@BlueCube3310 Can you take a look?

@akien-mga akien-mga added this to the 4.5 milestone Mar 24, 2025
@akien-mga akien-mga added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 24, 2025
@BlueCube3310
Copy link
Contributor

Tested it with several source formats, the first mip level looks as expected. The lower levels are corrupted

@bruvzg
Copy link
Member Author

bruvzg commented Mar 25, 2025

The lower levels are corrupted

Should be fixed.

Copy link
Contributor

@BlueCube3310 BlueCube3310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now. Thank you for the fast response!

@Repiteo Repiteo merged commit 350ac5b into godotengine:master Mar 25, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 25, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor topic:import topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants