Fix crash when removing breakpoints from DAP, and multiple fixes #104523
+99
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.3
ProfessorOctopus
added a commit
to ProfessorOctopus/godot
that referenced
this pull request
Mar 26, 2025
Fix crash when removing breakpoints from DAP, and multiple fixes godotengine#104523 by rsubtil TextureEditors: Compile shader/material only once godotengine#104488 by arkology Renderer: Warn when images need to be converted due to their formats being unsupported by hardware godotengine#104480 by BlueCube3310 Optimize startup times by using ubrk_clone instead of ubrk_open. godotengine#104455 by Ivorforce Pause audio when game is paused godotengine#104420 by pafuent Optimize reverb by removing stray volatile from the undenormalize function signature. godotengine#104239 by Ivorforce Add Memory::alloc_static_zeroed to allocate memory that's filled with zeroes. godotengine#104124 by Ivorforce Switch occlusion culling to be based on depth instead of Euclidean distance godotengine#103798 by Rudolph-B Optimize Object::cast_to by assuming no virtual and multiple inheritance, gaining 7x throughput over dynamic_cast. godotengine#103708 Ivorforce Optimize Projection::determinant() godotengine#103671 by MaxIsJoe Reuse Sprite3D meshes across nodes when possible. godotengine#103312 by chocola-mint Reduce frequency of save_default_environment() calls godotengine#102991 by KoBeWi Optimize GDScriptLambdaCallable by skipping the unnecessary ObjectDB lookup for script. godotengine#102930 by Ivorforce
|
@rsubtil Thank you for the fixes, I have tried from this branch and breakpoints are fine, however I was never able to evaluate EncodedObjectAsID
|
|
Can confirm as well, and it is not related to these changes. I'll join the discussion on #104834 to find out more. |
akien-mga
approved these changes
Mar 31, 2025
Fixed, thanks for the heads-up! |
AThousandShips
approved these changes
Mar 31, 2025
AThousandShips
approved these changes
Mar 31, 2025
…data, source checksums not updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104078
Closes #95998 (very very likely)
This fixes an
use-after-freebug that would occur when deleting a breakpoint, because the breakpoint list was being iterated and deleted at the same time. This step is divided into two to prevent this issue. I've tested DAP usage in general under ASAN, and didn't find any other similar problems.This also includes other fixes for bugs that I identified while fixing it, and since I haven't found cases reporting similar behavior, I decided to bundle it all here as well:
Listunnecessarily whenVectoris more efficient and straighforwardDAP::Stackframeinfo from scope IDs mapping, not only to simplify the code, but to avoid using the map inneficiently (it was used to search for keys and values)DAP::Sourcewhenever breakpoints are requested, as it's likely the file may have changed in this caseDAP::Sources are also now cached and shared between different objects.