CheckButton checked/unchecked icon can be on both sides

[pafuent]

If inverted is set to true on CheckButton the checked/unchecked icon will be drawn in the right for for right-to-left layouts or in the left for left-to-right layouts.

Naming is hard, so I'm open to name changes.

Inspiration: https://youtu.be/cJ5Rkk5fnGg?list=PLeG_dAglpVo6TS0q858NajyeglRuvb7hs&t=923

[pafuent]

FYI @njamster

[Calinou]

From an UX perspective, is there a good reason to invert the CheckButton position while staying on a given typesetting configuration (LTR or RTL)? I can understand the aesthetics aspect, but I wonder if this can decrease usability if not used carefully.

[pafuent]

if this can decrease usability if not used carefully

If you are worried if this wont work when you switch from LTR or RTL (or vice-versa) the code takes that in consideration and invert works as expected in both cases:

• inverted on LTR means checked/unchecked icon on the left
• inverted on RTL means checked/unchecked mirrored icon on the right

[AThousandShips]

I think "invert" is too generic, at first glance I'd assume it meant the checked state was inverted so it was visible as checked when unpressed and vice versa

[Mickeon]

I may suggest inverted_side or mirrored but there may be no real winner here. As of writing this I cannot check, but there may be some Controls that have similar behavior to take inspiration from.

Either way, me too. I'm unsure what purpose this serves UX-wise. Even if it was talked about, I'm not sure it's useful.

[pafuent]

mirrored is being used as a suffix for theme items related to right-to-left layouts, so could be confusing to use it because in this case it will affect right-to-left and left-to-right layouts.

[njamster]

Personally, I think a checkbox_position enum with two options, "Beginning" and "End", would work best?

As to the purpose of this: I'll openly admit it's mostly motivated by aesthetics and personal preference. As mentioned in my talk, it can be worked around relatively easily – so personally I don't care if this is added or not. That being said, the workaround is quite verbose (involving three nodes and a script) for how little it achieves (moving the checkbox).

[KoBeWi]

You can work it around by swapping CheckBox icons with CheckButton's. You don't even need a script.

godot.windows.editor.dev.x86_64_4qbZvu0Xnv.mp4

[njamster]

Nice catch, thanks! :) Still, I'd argue that using another node with a different texture isn't exactly an obvious solution to the problem, while the documentation recommends choosing between CheckButton and CheckBox based on whether toggling it has an immediate effect or not. So while this simplifies the workaround, I'd still consider it an improvement if no workaround would be needed in the first place, and one could pick the position of the toggle button manually.

[KoBeWi]

tbh we could merge CheckBox and CheckButton into a single class with 3 modes (checkbox, checkbutton, radio button), with option to display the icon on either side. But that's Godot 5 material.

[MarianoGnu]

I believe this toggle should be part of the theme settings that could be overridden by the node, but usually if you set it in one Button, you want it to all of them, so changing it in the default theme sounds like the best place to do it.
I also agree the name invert is too generic and is confusing because user may not understand the context

[pafuent]

I'll try to come up with an updated version that address most of the comments