Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astcenc to the upstream 5.3.0 release #104462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solidpixel
Copy link

@solidpixel solidpixel commented Mar 21, 2025

This is a maintenance update for the Arm astcenc ASTC compressor, updating to the upstream 5.3.0 release. This brings the compressor inline with the latest Khronos Data Format Specification, v1.4.0, which clarified some ambiguous compressor functionality. There are no major changes in terms of core codec functionality compared to the 4.8.0 release that Godot had been using, but many minor optimizations, bug fixes, and image quality improvements.

The biggest improvement for Godot users is that builds using the Visual Studio cl.exe compiler will now correctly default to the SSE2-optimized backend (on x86-64) and NEON-optimized backend (on Arm64) rather than the reference C backend. This makes compression more than 3 times faster. Builds using other compilers (GCC, LLVM/Clang) were not impacted by the underlying issue, and see no performance uplift.

(For avoidance of doubt, I'm the upstream maintainer for astcenc at Arm).

This is mostly a maintenance update that brings the compressor inline
with the recently published Khronos Data Format Specification 1.4
release which clarified some ambiguity in the specification. This update
also gives minor codec optimizations, bug fixes, and image quality
improvements.

The biggest improvement for Godot is that builds using MSVC cl.exe will
now correctly default to the SSE2-optimized backend rather than the
reference C backend. This makes compression more than 3 times faster.
Builds using other compilers (GCC, LLVM/Clang) were not impacted by the
underlying issue, and see no performance uplift.
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing but otherwise good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants