Editor: Replace TextEdit with EditorSpinSlider for XR Action Set Priority #104461
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodetrick
changed the title
lodetrick
changed the title
lodetrick
force-pushed
the
action-map-ui
branch
from
1d1bf83 to
6ae404b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the editor UI for Action Sets, the priority of an Action Set is currently changed with a TextEdit node, this commit changes it to an EditorSpinSlider. This clarifies the internal structure of the Action Set by making it clear inside the editor that the priority is an integer.
In order to test this change, create a new project and go to Project Settings -> XR -> OpenXR -> Enabled, and enable XR. This should create a tab on the bottom bar labeled "OpenXR Action Map." This tab is where the change is visible, directly to the left of the
plusbutton in the Godot action set.Before the change:
After the change:
