Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Fix Window size changes ignored when node is not in tree #100746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Android: Fix Window size changes ignored when node is not in tree #100746

wants to merge 1 commit into from
+3 −3

Conversation

syntaxerror247
Copy link
Contributor

Fixes a regression from my PR (#99669) on Android where window size changes are ignored if the node is not in the tree.

Fixes #100743

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner December 22, 2024 17:48
@AThousandShips AThousandShips added this to the 4.4 milestone Dec 22, 2024
@AThousandShips AThousandShips requested a review from a team December 22, 2024 19:17
Sauermann
Sauermann approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally checking for is_inside_tree() should correctly solve the reported bug. Haven't tested it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug platform:android regression topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Window ignores size changes when not in tree (Android only)
4 participants
@syntaxerror247 @m4gr3d @Sauermann @AThousandShips