Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused headers #100739

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove unused headers #100739

wants to merge 6 commits into from

Conversation

YYF233333
Copy link
Contributor

As #100564 and #100634 are merged smoothly, I think it is time to pace a little bit faster. Here are cleanups for other parts of the engine.

@@ -28,12 +28,12 @@
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/

#include "core/config/project_settings.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move down below, it should be after the other headers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This head is required by rasterizer_gles3.h but not directly, should be some complex dependencies, I revert this change and leave it for following works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then that's an issue to solve separately I would say

editor/add_metadata_dialog.cpp Show resolved Hide resolved
editor/export/lipo.cpp Show resolved Hide resolved
scene/3d/fog_volume.cpp Show resolved Hide resolved
scene/3d/physics/physical_bone_3d.cpp Show resolved Hide resolved
scene/main/http_request.cpp Show resolved Hide resolved
scene/resources/shader_include.cpp Show resolved Hide resolved
Co-authored-by: A Thousand Ships <[email protected]>
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't select them all, but quite a few instances of <cstdint>/<stdint.h>/<stddef.h> are redundant when core/typedefs.h is already included. Feel free to disregard if that feels outside the scope of this PR

scene/main/multiplayer_api.cpp Outdated Show resolved Hide resolved
scene/main/scene_tree.cpp Outdated Show resolved Hide resolved
@YYF233333
Copy link
Contributor Author

Couldn't select them all, but quite a few instances of <cstdint>/<stdint.h>/<stddef.h> are redundant when core/typedefs.h is already included. Feel free to disregard if that feels outside the scope of this PR

Yes, I think there should be some more redundant headers, but as they are actually used clangd would not pop a warning so it cost some more to distinguish them. I plan to go through all headers a second time for foward declarations, will try catching missing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants