-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused headers #100739
base: master
Are you sure you want to change the base?
Remove unused headers #100739
Conversation
drivers/gles3/storage/config.cpp
Outdated
@@ -28,12 +28,12 @@ | |||
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ | |||
/**************************************************************************/ | |||
|
|||
#include "core/config/project_settings.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move down below, it should be after the other headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This head is required by rasterizer_gles3.h
but not directly, should be some complex dependencies, I revert this change and leave it for following works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then that's an issue to solve separately I would say
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't select them all, but quite a few instances of <cstdint>
/<stdint.h>
/<stddef.h>
are redundant when core/typedefs.h
is already included. Feel free to disregard if that feels outside the scope of this PR
modules/openxr/editor/openxr_select_interaction_profile_dialog.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Thaddeus Crews <[email protected]>
Yes, I think there should be some more redundant headers, but as they are actually used clangd would not pop a warning so it cost some more to distinguish them. I plan to go through all headers a second time for foward declarations, will try catching missing ones. |
As #100564 and #100634 are merged smoothly, I think it is time to pace a little bit faster. Here are cleanups for other parts of the engine.