Core: Refactor log_error to unify color handling
#100724
Open
+28
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
force-pushed
the
core/log_error-refactor
branch
from
643187d to
163fca0
Compare
• Can now detect & output color on CI
Repiteo
force-pushed
the
core/log_error-refactor
branch
from
163fca0 to
5bd7cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes many of the improvements proposed in the above PR, minus the somewhat contentious dim-color addition. Now uniformly detects if the environment is appropriate for colored output utilizing #91201's
get_stdout_type(), and properly detects CI for colored output on GitHub Actions. The colors have also been unified so the standard versions (excludinggray) don't use the "intense" palette — this was already the case on Windows, but Mac/Linux mixed the two — as consoles automatically swap intensity based on if the text is bold or not