Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sdf9 ➡️ sdf12 #1356

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Merge sdf9 ➡️ sdf12 #1356

merged 2 commits into from
Jan 12, 2024

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jan 12, 2024

➡️ Forward port

Port sdf9 ➡️ sdf12

Branch comparison: sdf12...sdf9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey added 2 commits January 5, 2024 16:08
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from scpeters as a code owner January 12, 2024 17:41
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a9dad5) 92.14% compared to head (5fab7a4) 92.14%.
Report is 3 commits behind head on sdf12.

Additional details and impacted files
@@           Coverage Diff           @@
##            sdf12    #1356   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          79       79           
  Lines       13126    13126           
=======================================
  Hits        12095    12095           
  Misses       1031     1031           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Collaborator Author

azeey commented Jan 12, 2024

CI failed due to infrastructure issues. Will go ahead and merge since this is just a changelog diff.

@azeey azeey merged commit 0bfb39e into gazebosim:sdf12 Jan 12, 2024
12 of 14 checks passed
@azeey azeey deleted the 9_to_12 branch January 12, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants