Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HKG: Car Port for Genesis G80 2024 (2.5T, HDA2) #1132

Merged
merged 8 commits into from
Sep 27, 2024
Merged

HKG: Car Port for Genesis G80 2024 (2.5T, HDA2) #1132

merged 8 commits into from
Sep 27, 2024

Conversation

sunnyhaibin
Copy link
Contributor

Checklist

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 66eaa6c3b6b2afc6/00000009--3a5199aabe
  • route with stock system: 66eaa6c3b6b2afc6/00000006--1fb9d3a187
  • car harness used (if comma doesn't sell it, put N/A): Harness P
  • car architecture: CAN-FD

Superseded commaai/openpilot#32633

@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@sunnyhaibin sunnyhaibin mentioned this pull request Aug 20, 2024
Closed
jyoung8607
jyoung8607 requested changes Sep 25, 2024
View reviewed changes
@jyoung8607 jyoung8607 marked this pull request as draft September 25, 2024 00:31
This was referenced Sep 25, 2024
Merged
Merged
@sunnyhaibin sunnyhaibin marked this pull request as ready for review September 26, 2024 04:51
@sunnyhaibin
Merge remote-tracking branch 'commaai/opendbc/master' into g80-2024-f…
5fdc89a 
…l-port

# Conflicts:
#	opendbc/car/hyundai/interface.py
#	opendbc/car/torque_data/override.toml
@jyoung8607 jyoung8607 merged commit d2ca186 into commaai:master Sep 27, 2024
3 checks passed
@sunnyhaibin sunnyhaibin deleted the g80-2024-fl-port branch September 27, 2024 03:34
@sunnyhaibin sunnyhaibin mentioned this pull request Sep 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyoung8607 jyoung8607 jyoung8607 approved these changes

Assignees
No one assigned
Labels
car related to opendbc/car/ fingerprint hyundai
Projects
Car Ports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyhaibin @jyoung8607