Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library creation #341

Merged
merged 2 commits into from
Jan 13, 2024
Merged

library creation #341

merged 2 commits into from
Jan 13, 2024

Conversation

daichengxin
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@daichengxin daichengxin changed the title Dev library creation Jan 13, 2024
@daichengxin daichengxin linked an issue Jan 13, 2024 that may be closed by this pull request
quantms failing with a big dataset 15K files #339
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 666467d

+| ✅ 160 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-13 16:18:21

This was linked to issues Jan 13, 2024
Improve the skip pre-analysis parameter logic #337
Closed
Benchmark skip pre-analysis vs full preanalysis. #338
Closed
We should dynamically configure some of the steps depending of the experiment size. #340
Open
This was unlinked from issues Jan 13, 2024
Improve the skip pre-analysis parameter logic #337
Closed
We should dynamically configure some of the steps depending of the experiment size. #340
Open
@ypriverol ypriverol self-requested a review January 13, 2024 17:08
@ypriverol ypriverol merged commit e9ae266 into bigbio:dev Jan 13, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypriverol ypriverol ypriverol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quantms failing with a big dataset 15K files Benchmark skip pre-analysis vs full preanalysis.
2 participants
@daichengxin @ypriverol