Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark skip pre-analysis vs full preanalysis. #338

Closed
ypriverol opened this issue Jan 11, 2024 · 2 comments · Fixed by #341
Closed

Benchmark skip pre-analysis vs full preanalysis. #338

ypriverol opened this issue Jan 11, 2024 · 2 comments · Fixed by #341
Assignees
Labels
Milestone

Comments

@ypriverol
Copy link
Member

In a recent PR #335, we introduced the possibility to skip the pre-analysis step. Would be great to have some plots and results about how skipping pre-analysis will affect the final results. @daichengxin maybe reanalyzing one of the benchmark datasets for DIA without the pre-analysis step would be a good idea and share the results in here.

@daichengxin
Copy link
Collaborator

PXD026600 are used to benchmark. Each concentration has three technical replicates. Three strategies of library generation: 1. all files 2. select a file in each technical replicates group (total 16 file). 3. random sampling 16 files. Performance is indeed degraded, compared to the full library.

image
image
image

@ypriverol
Copy link
Member Author

Results are almost identical.

@ypriverol ypriverol linked a pull request Jan 13, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants