Skip to content

Split BufferedEvent from Event #20101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 14, 2025
Merged

Split BufferedEvent from Event #20101

merged 6 commits into from
Jul 14, 2025

Conversation

tim-blackbird
Copy link
Contributor

Objective

I think we should axe the shared Event trait entirely
It doesn't serve any functional purpose, and I don't think it's useful pedagogically
@alice-i-cecile on discord

Solution

  • Remove Event as a supertrait of BufferedEvent
  • Remove any Event derives that were made unnecessary
  • Update release notes

@tim-blackbird tim-blackbird added A-ECS Entities, components, systems, and events X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 12, 2025
SpecificProtagonist
SpecificProtagonist approved these changes Jul 12, 2025
View reviewed changes
Copy link
Contributor

@SpecificProtagonist SpecificProtagonist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this :)

@tim-blackbird @SpecificProtagonist
Apply suggestions from code review
1d85375 
Co-authored-by: SpecificProtagonist <[email protected]>
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers and removed X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 12, 2025
@alice-i-cecile alice-i-cecile requested a review from cart July 12, 2025 15:09
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jul 12, 2025
@tim-blackbird tim-blackbird mentioned this pull request Jul 12, 2025
Merged
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 14, 2025
@alice-i-cecile
Copy link
Member

Yeah I think I'm on board for this, provided we do it before 0.17. Otherwise, I think we do the auto-derive in EntityEvent

From @cart in the Observer Overhaul working group.

Merged via the queue into bevyengine:main with commit 4e9e78c Jul 14, 2025
36 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2025
@tim-blackbird
Remove the need to derive Event when deriving EntityEvent (#20104)
57086d4 
# Objective
Since we are planning to remove the need to derive both `Event` and
`EntityEvent` in 0.17 either way, I'm choosing to do the easy thing in
this PR so we can get the churn out of the way early.

Context from
[discord](https://discordapp.com/channels/691052431525675048/1383928409784193024/1393463673137401946).
Related to, and will conflict slightly with #20101.

## Solution

- Derive `Event` as part of the `EntityEvent` derive
- Remove any `Event` derives that were made unnecessary
- Update release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perry-blueberry perry-blueberry perry-blueberry approved these changes

@SpecificProtagonist SpecificProtagonist SpecificProtagonist approved these changes

@cart cart Awaiting requested review from cart

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@tim-blackbird @alice-i-cecile @perry-blueberry @SpecificProtagonist