Remove the need to derive Event when deriving EntityEvent
#20104
+50
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
added
A-ECS
BD103
reviewed
Jul 12, 2025
| @@ -60,13 +60,13 @@ impl Mine { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Event, EntityEvent)] | |||
There was a problem hiding this comment.
Just checking: was EntityEvent purposefully removed here, or was this a mistake?
There was a problem hiding this comment.
On purpose :) ExplodeMines is only used without an entity target. I presume EntityEvent was derived by accident before
viridia
approved these changes
Jul 12, 2025
BD103
approved these changes
Jul 13, 2025
tim-blackbird
added
S-Ready-For-Final-Review
|
I still think that an associated type or const or something on a single trait is going to be better here in the end, but this will make that migration easier regardless and it's a nicer state for now. |
|
@tim-blackbird ping me when the merge conflicts I'm about to generate are resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Since we are planning to remove the need to derive both
EventandEntityEventin 0.17 either way, I'm choosing to do the easy thing in this PR so we can get the churn out of the way early.Context from discord. Related to, and will conflict slightly with #20101.
Solution
Eventas part of theEntityEventderiveEventderives that were made unnecessary