Skip to content

Make tracing Optional for bevy_utils #15879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Make tracing Optional for bevy_utils #15879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb237d8
Make `tracing` Optional for `bevy_utils`
bushrat011899 Oct 13, 2024
c171598
Only use `log` if required
bushrat011899 Oct 16, 2024
90872cc
Include comment explaining re-export.
bushrat011899 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/bevy_utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,26 @@ license = "MIT OR Apache-2.0"
keywords = ["bevy"]

[features]
default = ["std", "serde"]
default = ["std", "serde", "tracing"]
std = [
"alloc",
"tracing/std",
"log/std",
"ahash/std",
"dep:thread_local",
"ahash/runtime-rng",
"tracing?/std",
]
alloc = ["hashbrown/default"]
tracing = ["dep:tracing"]
detailed_trace = []
serde = ["hashbrown/serde"]

[dependencies]
ahash = { version = "0.8.7", default-features = false, features = [
"compile-time-rng",
] }
tracing = { version = "0.1", default-features = false }
log = { version = "0.4", default-features = false }
tracing = { version = "0.1", default-features = false, optional = true }
hashbrown = { version = "0.14.2", default-features = false }
bevy_utils_proc_macros = { version = "0.15.0-dev", path = "macros" }
thread_local = { version = "1.0", optional = true }
Expand Down
8 changes: 8 additions & 0 deletions crates/bevy_utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,16 @@ pub use hashbrown;
#[cfg(feature = "std")]
pub use parallel_queue::*;
pub use time::*;

#[cfg(feature = "tracing")]
pub use tracing;

#[cfg(not(feature = "tracing"))]
// In cases where the tracing crate cannot be used, we can instead rely on log to
// provide most of the required functionality.
// Exporting log as tracing allows this decision to have minimal impact on consumers.
pub use log as tracing;

#[cfg(feature = "alloc")]
use alloc::boxed::Box;

Expand Down
Loading