Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracing Optional for bevy_utils #15879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Made tracing optional (behind the tracing feature, enabled by default).
  • Switched to using log within bevy_utils, and exported it as log.

Testing

  • cargo build --target thumbv4t-none-eabi

Migration Guide

If you were using bevy_utils with default features disabled, and you relied on the tracing re-export, either enable the tracing feature, or switch to using the log export, or import tracing into your project directly.

Notes

tracing has built-in support for capturing logs from log and this is enabled by default. The biggest loss going from log to tracing is the loss of info_span/etc. Otherwise, the crates are largely identical in behaviour, with log having no dependencies and more popularity on crates.io.

@bushrat011899 bushrat011899 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Dependencies A change to the crates that Bevy depends on A-Utils Utility functions and types X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 13, 2024
@bushrat011899 bushrat011899 added this to the 0.16 milestone Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Utils Utility functions and types C-Dependencies A change to the crates that Bevy depends on D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant