Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chromedriver-helper and use system binaries #19

Closed
wants to merge 1 commit into from

Conversation

benthorner
Copy link
Contributor

Previously we used the chromedriver-helper gem to automatically download
a suitable chromedriver binary for use with headless testing. This gem
is no longer maintained, and since work had already begun to start using
the system binary, it seems best to drop it altogether.

flavorjones/chromedriver-helper#83

A system binary for chromedriver should already installed on all Jenkins
agents, but a Puppet gem is still needed to install it on all Dev VMs.

Previously we used the chromedriver-helper gem to automatically download
a suitable chromedriver binary for use with headless testing. This gem
is no longer maintained, and since work had already begun to start using
the system binary, it seems best to drop it altogether.

flavorjones/chromedriver-helper#83

A system binary for chromedriver should already installed on all Jenkins
agents, but a Puppet gem is still needed to install it on all Dev VMs.
@benthorner
Copy link
Contributor Author

benthorner commented Apr 24, 2019

One possible issue with this is that an older version of chromedriver-helper used to add it's own chromedriver binstub, which is still present on older machines. This means running bundle exec chromedriver will try to use the old binstub, which won't work if the gem isn't there anymore; the easiest thing to do is just to manually find and remove the old binstub, as bundler doesn't clean them up - this stops it getting picked-up on the path and lets the system one be used as expected.

Example of removing: ~/.rbenv/versions/2.5.3/bin/chromedriver

@benthorner
Copy link
Contributor Author

Closing this in favour of #18. The nice thing about webdrivers is that it automatically updates chromedriver when a new version of Chrome is released, so it's definitely worth using to avoid the faff of doing this manually every time.

@benthorner benthorner closed this Apr 25, 2019
@benthorner benthorner deleted the remove-chromedriver-helper branch April 25, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant