Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force using system chromedriver everywhere #986

Closed
wants to merge 1 commit into from

Conversation

benthorner
Copy link
Contributor

@benthorner benthorner commented Apr 24, 2019

Hopefully we can remove this if alphagov/govuk_test#19 goes down well.

@kevindew
Copy link
Member

@benthorner could you explain why we'd want to force it?

Is there a discussion going on between the competing PRs of alphagov/govuk_test#18 and alphagov/govuk_test#19

By the number of reverts there seems to be a lot of problems with attempting to use system chromedriver and it doesn't look like any other apps use this env var. It's never been really explained what the benefit of using system chromedriver offers over using a provided one.

@benthorner
Copy link
Contributor Author

@kevindew sure - all of the problems we've had are actually due to the gem, rather than the system chromedriver. The gem theoretically allows us to lock to a version of chromedriver, but this has lead to two problems:

  • New releases of Chrome are installed on systems before the gem updates to cover the new version (my local build is failing because of this)
  • Google pulls all old releases of chromedriver, so version locks aren't actually feasible

It seems the main reason for using the gem was a 'handy' way to auto-install chromedriver, but it's actually on all our systems anyway. I can always set this locally, so perhaps this isn't necessary for everyone, although I expect your build will break soon too :-|.

@kevindew
Copy link
Member

@benthorner sure, do you know if you continue getting those problems if you use the webdrivers gem? I don't think that is tied to particular versions in the gem from what I can tell.

Since the idea to use the chromedriver path has caused problems each time, I'm a bit wary of it - and it's also another dependency to install and manage for a dev.

@benthorner
Copy link
Contributor Author

Closing in favour of further discussion on alphagov/govuk_test#19.

@benthorner benthorner closed this Apr 25, 2019
@benthorner benthorner deleted the force-system-chromedriver branch April 25, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants