Upgrade chromedriver helper to webdrivers #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gem is now deprecated and can be replaced with the better supported webdrivers.
edwardkerry
force-pushed
the
upgrade_chromedriver-helper_to_webdrivers
branch
2 times, most recently
from
a4e31d1
to
f8b21eb
Compare
thomasleese
reviewed
Apr 24, 2019
👍 wasn't sure if this should be done here or in the version change PR |
thomasleese
reviewed
Apr 24, 2019
thomasleese
reviewed
Apr 24, 2019
edwardkerry
force-pushed
the
upgrade_chromedriver-helper_to_webdrivers
branch
2 times, most recently
from
3deff5c
to
fa67267
Compare
|
Having had and fixed this problem myself, I've ended up with my own solution - sorry for the duplication. What do people think about this alternative: #19. The problem we've had in the past is that Google retract old versions of Chrome when they release new ones, so the version-management aspect of these gems is a bit of a fantasy :-|. (Companion PR that should hopefully do the trick alphagov/govuk-puppet#9029.) |
benthorner
reviewed
Apr 25, 2019
benthorner
reviewed
Apr 25, 2019
thomasleese
added a commit
to alphagov/smokey
that referenced
this pull request
Apr 26, 2019
chromedriver-helper is now deprecated and they recommend switching to webdrivers. This is similar to what we're doing for alphagov/govuk_test#18. The reason Smokey currently doesn't use govuk_test is that the Smokey testing environment is very different to an app testing environment, however we could aim to make govuk_test more customisable so we could switch over in the future.
edwardkerry
force-pushed
the
upgrade_chromedriver-helper_to_webdrivers
branch
from
d125283
to
8e38ca3
Compare
thomasleese
approved these changes
Apr 26, 2019
benthorner
reviewed
Apr 26, 2019
benthorner
reviewed
Apr 26, 2019
benthorner
approved these changes
Apr 29, 2019
edwardkerry
force-pushed
the
upgrade_chromedriver-helper_to_webdrivers
branch
from
6275547
to
af804f1
Compare
edwardkerry
force-pushed
the
upgrade_chromedriver-helper_to_webdrivers
branch
from
af804f1
to
196c751
Compare
thomasleese
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromedriver-helpersis now deprecated and can be replaced with the bettersupported
webdrivers.webdriverscauses an issue withwebmock. This Gem will now configure Webmock for consuming applications.Trello