Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chromedriver-helper and use system binaries #19

Closed
wants to merge 1 commit into from
Closed

Remove chromedriver-helper and use system binaries #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
useful summary for people upgrading their application, not a replication
of the commit log.

* Remove the now-deprecated chromedriver-helper gem in favour of system binaries

## 0.4.2

* Silence Puma logs during spec suite.
Expand Down
1 change: 0 additions & 1 deletion govuk_test.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "capybara"
spec.add_dependency "chromedriver-helper"
spec.add_dependency "ptools"
spec.add_dependency "puma"
spec.add_dependency "selenium-webdriver"
Expand Down
7 changes: 0 additions & 7 deletions lib/govuk_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@ def self.configure(options = {})
chrome_options = %w(headless disable-gpu)
chrome_options << "--window-size=#{options[:window_size]}" if options[:window_size]

if ENV['GOVUK_TEST_USE_SYSTEM_CHROMEDRIVER']
# Use the installed chromedriver, rather than chromedriver-helper
Selenium::WebDriver::Chrome.driver_path = File.which("chromedriver")
else
require 'chromedriver-helper'
end

Capybara.register_driver :headless_chrome do |app|
capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
chromeOptions: { args: chrome_options }
Expand Down