Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] More mac Examples added #766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Coding-George
Copy link

@Coding-George Coding-George commented Feb 21, 2025

Description

Added more examples that Run on MAC Os. sph_liquid_on_mac.py, pbd_liquid_on_mac.py and control_your_robot_on_mac.py

Related Issue

Resolves Genesis-Embodied-AI/Genesis#

Motivation and Context

How Has This Been / Can This Be Tested?

Testing Environment:

conda 25.1.1
Python 3.12.9
macOS Sequoia Version 15.3.1
Macbook Air M2

Screenshots (if appropriate):

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@duburcqa
Copy link
Collaborator

duburcqa commented Mar 3, 2025

Do you think that the current implementation of interactive viewer on Mac OS made this PR obsolete ? The only issue is the graphical window only being responsible when a simulation is running.

@@ -4,6 +4,9 @@

import genesis as gs

import os
os.environ["IMAGEIO_FFMPEG_EXE"] = "/opt/homebrew/bin/ffmpeg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary ? On my side, ImageIO was shipping with its own version that was working just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants