AOA Sensor #31570
Open
AOA Sensor #31570
+435
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure from previously written honeywell pitot code. That will then use the pressure to calculate aoa based on change in pressure. Currently having problems with an endless cycle of 'getting params 1' dialogue box not fully completing.
peterbarker
requested changes
Nov 26, 2025
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Need to understand how this might interact with @Ryanf55 's airspeed data library.
Very much a partial review only.
| // public: // everything below is accessible from outside the class | ||
| // AP_Airspeed_PitotHoneywell(AP_Airspeed &frontend, int8_t bus, uint8_t address); | ||
|
|
||
| // /* constructor that i called when the backend is created. frontend is the reference to the main airspeed mananger (AP_Airspeed) |
Contributor
There was a problem hiding this comment.
Many comments to remove
| // float _last_q = 0.0f; // stores the last measured differential pressure. EKF reads this in update() | ||
| // bool _healthy = false; // tracks whether the last read succeeded. if read ok -> true, if error/no response -> false. it prevents bad data feeding into flight controller | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Please provide a link to the datasheet for the device.
| #include <AP_HAL/AP_HAL.h> | ||
| #include "AP_Airspeed_Backend.h" | ||
|
|
||
| class AP_Airspeed_PitotHoneywell : public AP_Airspeed_Backend { |
Contributor
There was a problem hiding this comment.
This is a strange name for the device.
Comment on lines
+64
to
+66
| float _last_q = 0.0f; | ||
| float _last_temperature = 0.0f; | ||
| bool _healthy = false; |
Contributor
There was a problem hiding this comment.
Don't zero these; ArduPilot implicitly zeroes allocated memory, so this just wastes flash
|
|
||
| // }; | ||
| #pragma once | ||
| #include <AP_HAL/AP_HAL.h> |
Contributor
There was a problem hiding this comment.
Suggested change
| #include <AP_HAL/AP_HAL.h> | |
| #pragma once | |
| #include "AP_Airspeed_config.h" | |
| #if AP_AIRSPEED_PITOTHONEYWELL_ENABLED | |
| #include <AP_HAL/AP_HAL.h> |
... but adjusted for a better device name
| @@ -0,0 +1,254 @@ | |||
| // #include "AOA_AOA.h" | |||
Contributor
There was a problem hiding this comment.
more comments to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added capability to use new pressure transducer to read dynamic pressure from previously written honeywell pitot code. That will then use the pressure to calculate aoa based on change in pressure. Currently having problems with an endless cycle of 'getting params 1' dialogue box not fully completing.