AP_HAL_ChibiOS: Fix regression in MCU max and min volt logging #29417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleRos
force-pushed
the
pr/mcu-volt-fix
branch
from
919e12e to
a5533b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression in the max and min MCU voltage in the logs, as described in this issue: #29147
Tested on CubeOrangePlus and MatekH743 with copter firmware.
Master:
This PR:
Note, however that this does reset it at 20 Hz, whereas MCU only gets logged at 10 Hz (on copter, at any rate).
AFAICT this was the previous behaviour as well though.