Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: Tiltrotor: fix has_vtol_motor function #29415

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Mar 3, 2025

This fixes a by reported by @jcproulx in #29404.

It was always checking the first motor rather than any motor. The _have_vtol_motor bool is used in the has_vtol_motor function which is only used here:

if (quadplane.tiltrotor.enabled() && !quadplane.tiltrotor.has_vtol_motor() && !quadplane.tiltrotor.has_fw_motor()) {
// All motors tilting, Use a combination of vertical and forward throttle based on curent tilt angle
// scale from all VTOL throttle at airspeed_reached_tilt to all forward throttle at fully forward tilt
// this removes a step change in throttle once assistance is stoped

The goal of that code is to smooth the handover of throttle control from VTOL to FW in the transition timer phase on vehicles that had all motors tilting.

@tridge tridge merged commit b648b55 into ArduPilot:master Mar 3, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending
Development

Successfully merging this pull request may close these issues.

2 participants