AP_Generator: FuelCell: increase max data rate #29414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without, we log exactly the 300 bytes/second limit and the generator is unhealthy: With this fix we get the true data rate of about 350 bytes per second. |
CraigElder
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point between when the comment was added on the function and now the generator scheduler rate was dropped to 10Hz. 30 bytes read per call at 10Hz means a max of 300 bytes per second rather than the 600 bytes per second it would have been originally.
This bumps it up to 255 bytes for a max of 2550 bytes per second. These typically ruin on a serial port at 9600 baud so a max of 960 bytes per second. We could go lower, 50 or 100 bytes per call would be fine for the existing units, but this was a PITA to debug so some headroom is nice.