Fix dshot cancel race #29409
Open
Fix dshot cancel race #29409
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gives a crash dump for easier analysis. Don't enable on production aircraft
tridge
requested changes
Mar 3, 2025
| @@ -496,6 +496,11 @@ __RAMFUNC__ void RCOutput::bdshot_finish_dshot_gcr_transaction(virtual_timer_t* | |||
| #ifdef HAL_GPIO_LINE_GPIO56 | |||
| TOGGLE_PIN_DEBUG(56); | |||
| #endif | |||
| if (group->dshot_waiter == nullptr) { // transaction was cancelled, leave everything alone | |||
There was a problem hiding this comment.
i think this change won't work, when the bug happens 'this' is nullptr, so we are checking an incorrect memory location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #29379 fixes #29370
This ensures dshot_waiter is only manipulated inside a system lock. Tested on a Pavo20Pro