AP_GPS: discard SBF packets with claimed length > 256 bytes #29399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messages coming in with a size of 24120 bytes. It takes so long to try to read those bytes in (at the device's message rate) that we time out the GCS and try detecting again
so much more useful generally
Ryanf55
approved these changes
Mar 4, 2025
tridge
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to 3DR for supplying the hardware used to debug this!
@chiara-septentrio this is a MosaicX5 module connected to an ArduPilot periph node. We're reliably seeing bad bytes in the length field; this fix is necessary in case of true corruption, but it's a bit worrying how reliable this problem is!