Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_AccelCal:Remove an unusable return #29398

Merged
merged 1 commit into from
Feb 28, 2025
Merged

AP_AccelCal:Remove an unusable return #29398

merged 1 commit into from
Feb 28, 2025

Conversation

JulioCesarMatias
Copy link

At the end of void AP_AccelCal::update_status() there is a return; that shouldn't be there.

peterbarker
peterbarker requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got the right prefix - AP_AccelCal: .

But you also need it on the commit, not just on the PR title.

Let me know if you need help fixing this 9 our Wiki has instructions on the git operaitons required for this.

peterbarker
peterbarker approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IamPete1 IamPete1 merged commit 25c5cf1 into ArduPilot:master Feb 28, 2025
117 of 119 checks passed
@JulioCesarMatias JulioCesarMatias deleted the ap_accel_cal branch February 28, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

@IamPete1 IamPete1 IamPete1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulioCesarMatias @peterbarker @IamPete1