Plane: fence: refactor action cases #29356
Open
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
approved these changes
Feb 25, 2025
|
a bit of testing of the cases, with rally pt, ok to merge when tested |
IamPete1
force-pushed
the
plane_fence_action
branch
from
9dc2428 to
89b80a3
Compare
|
rebased, tested a fence breaches with both RTL and guided. Behaved as expected with and without fence return point, with and without rally points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the guided and RTL cases to share, they are independent. This simplifies #29280