AP_Soaring: Rate limit the NVF publishers to 4Hz #29064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
soaring-rate-limit-nvf-publisher
branch
from
2a5d0c6 to
41ce81a
Compare
|
It would be great if you could document that this table: https://ardupilot.github.io/MethodicConfigurator/TUNING_GUIDE_ArduCopter#612-configure-logging |
Note that we're hoping these will be very temporary messages. As in, it would be nice if 4.7 didn't go out the door with these. |
tridge
requested changes
Jan 21, 2025
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
soaring-rate-limit-nvf-publisher
branch
from
41ce81a to
817dd51
Compare
|
@Ryanf55 tested in its current form? |
Yep! 16 messages per second over 4 Named Values Floats gives us 4Hz. Working correctly. |
peterbarker
approved these changes
Jan 28, 2025
Comment on lines
+51
to
+52
| // store time of last NVT publish | ||
| #if HAL_SOARING_NVF_EKF_ENABLED |
There was a problem hiding this comment.
Suggested change
| // store time of last NVT publish | |
| #if HAL_SOARING_NVF_EKF_ENABLED | |
| #if HAL_SOARING_NVF_EKF_ENABLED | |
| // store time of last NVT publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from today's dev call covering #29030, we should rate limit the named value float thermal estimates to avoid flooding the GCS link.
I chose 4Hz.
See ArduPilot/MAVProxy#1500 for test instructions.
To test, I checked the packet reception times in mavproxy to see they are ~4hz.
This code block is disabled by default.